Skip to content

Conversation

@zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Sep 15, 2025

Found in #2261

This is the problem

+--- io.opentelemetry.semconv:opentelemetry-semconv-incubating -> 1.34.0-alpha
|    \--- io.opentelemetry.semconv:opentelemetry-semconv:1.34.0 -> 1.37.0

Bug remain even when fixing the currently wrong import statement - adding -alpha

   api("io.opentelemetry.semconv:opentelemetry-semconv-incubating:${semconvVersion}-alpha")

@zeitlinger zeitlinger requested a review from a team as a code owner September 15, 2025 10:01
@github-actions github-actions bot requested a review from trask September 15, 2025 10:01
@zeitlinger zeitlinger mentioned this pull request Sep 15, 2025

// Version to use to compile code and run tests.
val DEFAULT_JAVA_VERSION = JavaVersion.VERSION_17
val semconvVersion = "1.37.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could keep the version in dependencyManagement/build.gradle.kts to keep only having one place where versions are set and updated ? I'm not familiar with gradle resolution details but is there any particular reason we have to do this in otel.java-conventions ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to be a bug in gradle dependency resolution - at least I didn't find a way to keep the version where it is now.

@laurit do you have an idea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd replace enforcedPlatform with platform. I fail to see a reason why we should enforce this. cc @trask

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also doesn't help

configurations.configureEach {
      val b = isCanBeResolved && !isCanBeConsumed
      println("Configuring $name: add=$b")
      if (b || name.startsWith("test")) {
        extendsFrom(dependencyManagement)
      }
    }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @laurit - that was the issue!

@zeitlinger
Copy link
Member Author

@laurit it's ready

@trask trask added this pull request to the merge queue Sep 15, 2025
Merged via the queue into open-telemetry:main with commit e010e8d Sep 15, 2025
25 checks passed
@zeitlinger zeitlinger deleted the incubating-semconv branch September 15, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants